-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run label check on every commit and label change #359
Conversation
Shoot, now I'm worried that it'll interfere with the "Label new PR" action since those run quick and it might fail if the PR is submitted without labels but gets them from that action 😭 Let me see if we can actually expand the set of events rather than revert to the default set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense! LGTM, interesting problem. Thanks for jumping on it so fast
e28a0d3
to
aa1a9c0
Compare
Okay, I think I've got a solution! This should now cover all the default PR actions (commits, opening, reopening, etc) as well as when labels are updated. I'm going to let it run after this push, then try to change the labels to make sure the actions get triggered again. |
Worked like a charm! 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, very nice, thanks for the work here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving, good catch :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was about to say it doesn't make much sense to me to run this action on every commit but it seems necessary, as this is the default config the GH action project shows. Thanks for debugging this and finding the solution!
Description
Follow up to https://github.com/WordPress/openverse-infrastructure/pull/326 which required label checks for all merges into main, this was causing issues where a maintainer had to add & remove labels to re-trigger the check so a PR could be merged.
This action was previously set up to only run when the labels on a PR change. Since we've made this a required check, it makes sense to have this run unconditionally on every PR commit so that the check can pass (or fail) appropriately prior to a merge.
Testing Instructions
We might be able to see on this PR!
Checklist
Update index.md
).main
) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin